Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes from develop #48

Merged
merged 12 commits into from
Jan 24, 2022
Merged

Merge changes from develop #48

merged 12 commits into from
Jan 24, 2022

Conversation

fmalmeida
Copy link
Owner

@fmalmeida fmalmeida commented Jan 24, 2022

This PR handles the changes made in order to address issues #37 and #38. It also has an addition of a new quicktest profile as it was issued on #46.

Many thanks to @abhi18av for making the changes in this PR possible 👏🏼

abhi18av and others added 11 commits November 18, 2021 13:36
* Split out the config profiles

* Resolve the conflict using the upstream config
**Main change**

Processes, channels and workflow names have had its case names changed in order to meet nextflow's community standards.

**Commits**
* Refactor names
* refactor names in the workflows
* Update workflows/bacannot.nf
* Update workflows/bacannot.nf
* Apply suggestions from code review
* Update workflows/bacannot.nf wrt iceberg
* Accomodate code review and fix the channel name
* fix MERGE_ANNOTATIONS process case in line 331

Co-authored-by: Felipe Marques de Almeida <[email protected]>
@abhi18av
Copy link
Contributor

abhi18av commented Jan 24, 2022

You're welcome Felipe - happy to be of help 🙏 😊

Great job with the pipelines!

@fmalmeida fmalmeida merged commit 6ba5460 into master Jan 24, 2022
@fmalmeida fmalmeida deleted the develop branch January 26, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants