[MODFQMMGR-457] Re-instate old entity-type source values logic #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a86424c.
ncovercash
commented
Aug 29, 2024
| @@ -380,7 +380,6 @@ | |||
| valueFunction: 'lower(:value)', | |||
| source: { | |||
| entityTypeId: '58148257-bfb0-4687-8c42-d2833d772f3e', | |||
| columnName: 'cost_currency', | |||
There was a problem hiding this comment.
jackson's handling of json5, for some reason, uses a strategy for duplicate keys last-value-wins. IMO, this is stupid, but it technically matches the way JS handles it (grumble, grumble, there's even a draft spec to fix this)
|
kjain110
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
Purpose
Previously, entity types could source values from other entity types, however, this regressed in MODFQMMGR-378. It was not caught as all of our sources have been converted to either internal logic or API calls, however, some new tickets (MODFQMMGR-427) have exposed the need for this once again, resulting in the discovery of this regression.
Approach
Use the source entity type when sourcing values