Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSEARCH-617 Ignore hard-delete domain authority events #460

Merged
merged 9 commits into from
Nov 13, 2023

Conversation

GeloPakDev1
Copy link
Contributor

Purpose

Ignore hard-delete domain authority events

Approach

dd filter to Kafka listener to skip hard-delete subtype for authority domain events

Learning

Reference to AuthorityChangeFilterStrategy class in mod-entities-links

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
# Conflicts:
#	src/main/java/org/folio/search/integration/ResourceChangeFilterStrategy.java
#	src/test/java/org/folio/search/integration/ResourceChangeFilterStrategyTest.java
@psmagin
Copy link
Contributor

psmagin commented Nov 9, 2023

Also please update NEWS file

GeloPakDev1 and others added 2 commits November 9, 2023 16:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Contributor

@psmagin psmagin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix code smells provided by Sonar

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@GeloPakDev1 GeloPakDev1 requested a review from psmagin November 10, 2023 13:38
@GeloPakDev1 GeloPakDev1 merged commit e7c888f into master Nov 13, 2023
3 checks passed
GeloPakDev1 added a commit that referenced this pull request Nov 15, 2023
* MSEARCH-617 Ignore hard-delete domain authority events
@psmagin psmagin deleted the MSEARCH-617 branch February 21, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants