-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSEARCH-617 Ignore hard-delete domain authority events #460
Merged
+136
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeloPakDev1
requested review from
psmagin,
TsaghikKhachatryan,
viacheslavkol,
mukhiddin-yusuf and
andrei-razumnov
November 6, 2023 13:26
GeloPakDev1
force-pushed
the
MSEARCH-617
branch
from
November 6, 2023 13:32
f911c3a
to
8658749
Compare
mukhiddin-yusuf
requested changes
Nov 7, 2023
src/main/java/org/folio/search/integration/ResourceChangeFilterStrategy.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/search/integration/ResourceChangeFilterStrategy.java
Outdated
Show resolved
Hide resolved
GeloPakDev1
force-pushed
the
MSEARCH-617
branch
from
November 8, 2023 11:26
8658749
to
9a4cfb8
Compare
mukhiddin-yusuf
requested changes
Nov 8, 2023
src/main/java/org/folio/search/integration/ResourceChangeFilterStrategy.java
Outdated
Show resolved
Hide resolved
Loading status checks…
# Conflicts: # src/main/java/org/folio/search/integration/ResourceChangeFilterStrategy.java # src/test/java/org/folio/search/integration/ResourceChangeFilterStrategyTest.java
psmagin
previously requested changes
Nov 9, 2023
src/main/java/org/folio/search/integration/ResourceChangeFilterStrategy.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/search/integration/ResourceChangeFilterStrategy.java
Outdated
Show resolved
Hide resolved
Also please update NEWS file |
psmagin
reviewed
Nov 9, 2023
src/main/java/org/folio/search/integration/ResourceChangeFilterStrategy.java
Outdated
Show resolved
Hide resolved
GeloPakDev1
force-pushed
the
MSEARCH-617
branch
from
November 10, 2023 10:33
198e52c
to
53a21ae
Compare
psmagin
reviewed
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix code smells provided by Sonar
src/main/java/org/folio/search/integration/ResourceChangeFilterStrategy.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
mukhiddin-yusuf
approved these changes
Nov 10, 2023
TsaghikKhachatryan
approved these changes
Nov 13, 2023
GeloPakDev1
added a commit
that referenced
this pull request
Nov 15, 2023
Loading
Loading status checks…
* MSEARCH-617 Ignore hard-delete domain authority events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ignore hard-delete domain authority events
Approach
dd filter to Kafka listener to skip hard-delete subtype for authority domain events
Learning
Reference to AuthorityChangeFilterStrategy class in mod-entities-links