[UISAUTHCOM-42] Disable hyperlinks for user names in role details page if user doesn't have access to Users module #64
+29
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandberger
requested review from
zburke,
usavkov-epam,
alisher-epam and
aidynoJ
|
|
PS, @ryandberger, it felt like this work could/should easily be its own reusable component so I just did that in stripes-smart-components, folio-org/stripes-smart-components#1555. Tests are acting funny in CI (they pass locally 🙄 ) so feel free to merge this if you don't want to wait for me to sort that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ui-users.viewperm, wrap user names in<TextLink>which links to that user in the Users module. Otherwise, wrap in<span>.