STCLI-246 Add a proxy server to overcome issues with cookies SameSite policy. #350
Conversation
| @@ -5,6 +5,17 @@ module.exports.serverOptions = { | |||
| default: 3000, | |||
| group: 'Server Options:', | |||
| }, | |||
| startProxy: { | |||
There was a problem hiding this comment.
Should we have default value false as described in commands.md file?
There was a problem hiding this comment.
That's a good idea, @artem-blazhko ; all the other options here include a default property. Sure, undefined is already falsey so it won't change anything, but it's good to be explicit.
doc/commands.md
Outdated
| @@ -1146,6 +1148,10 @@ Serve a build previously created with "stripes build": | |||
| ``` | |||
| $ stripes serve --existing-build output | |||
| ``` | |||
| Serve a platform with a local proxy server that points to remove okapi server: | |||
| @@ -5,6 +5,17 @@ module.exports.serverOptions = { | |||
| default: 3000, | |||
| group: 'Server Options:', | |||
| }, | |||
| startProxy: { | |||
There was a problem hiding this comment.
That's a good idea, @artem-blazhko ; all the other options here include a default property. Sure, undefined is already falsey so it won't change anything, but it's good to be explicit.
lib/platform/tenant-config.js
Outdated
| @@ -11,6 +11,7 @@ const defaultConfig = { | |||
| showPerms: false, | |||
| hasAllPerms: false, | |||
| languages: ['en'], | |||
| useSecureTokens: false, | |||
There was a problem hiding this comment.
Why default to false? This will hard-coded to true in Sunflower, if not Ramsons.
There was a problem hiding this comment.
I set false because it wasn't present in here before. But since we have it as true in platform config then it doesn't hurt to set to true here as well
|
Description
After updates that involve using Cookies for authentication, developers could face issues that cookies wouldn’t be included in requests
Browsers refused to set cookies due to “SameSite=”Lax” attribute:
Since this is a browser limitation we can overcome this by setting up a local proxy server which would redirect requests to Okapi and back.
This server is included as part of stripes-cli, so that developers don't have to install any third-party software.
Added two new options to
servecommand:--startProxy--proxyPortScreenshots
ConEmu64_siErZJYdi2.mp4
Issues
STCLI-246