Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STSMACOM-835 avoid defaultProps in functional components #1480

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Conversation

zburke
Copy link
Member

@zburke zburke commented May 13, 2024

defaultProps for functional components will be deprecated in React v19 in favor of ES6 default parameters.

STSMACOM-835

`defaultProps` for functional components will be deprecated in React v19
in favor of ES6 default parameters.

STSMACOM-835
@zburke zburke requested a review from JohnC-80 May 13, 2024 15:11
Copy link

github-actions bot commented May 13, 2024

Jest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit a585e67. ± Comparison against base commit afca4c8.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 13, 2024

BigTest Unit Test Statistics

    1 files  ±0      1 suites  ±0   16s ⏱️ ±0s
502 tests ±0  464 ✔️ ±0  37 💤 ±0  1 ±0 
504 runs  ±0  466 ✔️ ±0  37 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit a585e67. ± Comparison against base commit afca4c8.

♻️ This comment has been updated with latest results.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
60.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@zburke
Copy link
Member Author

zburke commented Sep 17, 2024

ping @JohnC-80 , could we get this minor clean up merged before the R deadlines hit?

Copy link

Bigtest Unit Test Results

  1 files  ±0    1 suites  ±0   16s ⏱️ -1s
502 tests ±0  464 ✅  - 1  37 💤 ±0  1 ❌ +1 
504 runs  ±0  466 ✅  - 1  37 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 1267791. ± Comparison against base commit 0d31ba8.

Copy link

github-actions bot commented Sep 17, 2024

Bigtest Unit Test Results

  1 files  ±0    1 suites  ±0   14s ⏱️ ±0s
505 tests ±0  468 ✅ ±0  37 💤 ±0  0 ❌ ±0 
507 runs  ±0  470 ✅ ±0  37 💤 ±0  0 ❌ ±0 

Results for commit c2a075a. ± Comparison against base commit 7524e80.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Oct 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
60.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@zburke zburke merged commit 1fd99db into master Oct 3, 2024
24 of 25 checks passed
@zburke zburke deleted the STSMACOM-835 branch October 3, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants