Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-3137: Set default sorting to URL in componentDidMount and componentDidUpdate if it is missing. #2687

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Dmytro-Melnyshyn
Copy link
Contributor

@Dmytro-Melnyshyn Dmytro-Melnyshyn commented Dec 3, 2024

Purpose

Use default sorting only if it is not present in the URL (reset button pressed or sorting manually removed).

Approach

  • componentDidMount: if sort option is not present (manually removed), add it to searchParams;
  • componentDidUpdate: if sort option is not present (reset button hit), add it to searchParams.

Refs

UIIN-3137

Screenshots

2024-12-03_14h50_59.mp4

Copy link

github-actions bot commented Dec 3, 2024

Jest Unit Test Statistics

       1 files  ±0     253 suites  ±0   14m 34s ⏱️ +19s
1 015 tests ±0  1 013 ✔️ ±0  2 💤 ±0  0 ±0 
1 022 runs  ±0  1 020 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 6a97756. ± Comparison against base commit 01139b2.

@Dmytro-Melnyshyn Dmytro-Melnyshyn merged commit 1bb3c4c into master Dec 3, 2024
5 checks passed
@Dmytro-Melnyshyn Dmytro-Melnyshyn deleted the UIIN-3137 branch December 3, 2024 16:01
mariia-aloshyna pushed a commit that referenced this pull request Dec 6, 2024
…entDidUpdate if it is missing. (#2687)

(cherry picked from commit 1bb3c4c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants