Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIIN-3167: Fix errors after cancel edit/duplicate or 'Save & Close' consortial holdings/items #2705

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

OleksandrHladchenko1
Copy link
Contributor

@OleksandrHladchenko1 OleksandrHladchenko1 commented Jan 6, 2025

Purpose

  • Remove errors after cancel edit/duplicate or 'Save & Close' consortial holdings/items.

Approach

  • Add initialTenantId prop in order to have the ability to return to the initial tenant after cancelling edit/duplicate holdings/items.

Refs

UIIN-3167

Screenshots

Cancel edit/duplicate holdings

cancel.edit-duplicate.holding.mp4

Cancel edit/duplicate items

cancel.edit-duplicate.item.mp4

Edit/duplicate holdings

edit-duplicate.holding.mp4

Edit/duplicate items

edit-duplicate.item.mp4

Copy link

github-actions bot commented Jan 6, 2025

Jest Unit Test Statistics

       1 files  ±0     255 suites  ±0   15m 33s ⏱️ +31s
1 023 tests ±0  1 021 ✔️ ±0  2 💤 ±0  0 ±0 
1 030 runs  ±0  1 028 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 2439517. ± Comparison against base commit c565668.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
70.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Dmytro-Melnyshyn Dmytro-Melnyshyn requested a review from a team January 7, 2025 08:59
@OleksandrHladchenko1 OleksandrHladchenko1 merged commit 57a05f8 into master Jan 7, 2025
4 of 5 checks passed
@OleksandrHladchenko1 OleksandrHladchenko1 deleted the UIIN-3167 branch January 7, 2025 13:44
mariia-aloshyna pushed a commit that referenced this pull request Jan 13, 2025
…onsortial holdings/items (#2705)

(cherry picked from commit 57a05f8)
mariia-aloshyna added a commit that referenced this pull request Jan 13, 2025
* UIIN-3167: Fix errors after cancel edit/duplicate or 'Save & Close' consortial holdings/items  (#2705)

(cherry picked from commit 57a05f8)

* Release v12.0.9

---------

Co-authored-by: Oleksandr Hladchenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants