Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UITEN-299 Rewrite class components to functional ones (ui-tenant-settings module) #416

Merged
merged 8 commits into from
Aug 7, 2024

Conversation

vashjs
Copy link
Contributor

@vashjs vashjs commented Aug 1, 2024

In scope of this PR refactoring related to reweiting all class components to functional was completed. Details:

  • Rewrited all class components to functional ones (Except 4 classes which are using smart components and have to be classed)
  • All manifest replaced with hooks (Except 3 manifests which are using smart-components)
  • All stripes/router wrappers replaced with hooks
  • All tests updated based on new hooks
  • Refactored spaces, files structure, imports structure

Note: there are no functional changes, behavior of module should be the same. Code coverage will be increased in feature stories as it's out of scope.

Refs: UITEN-299, UITEN-300

Copy link

github-actions bot commented Aug 1, 2024

Jest Unit Test Statistics

    1 files  ±0  28 suites  ±0   2m 14s ⏱️ -7s
109 tests ±0  97 ✔️ ±0  12 💤 ±0  0 ±0 
111 runs  ±0  99 ✔️ ±0  12 💤 ±0  0 ±0 

Results for commit 77a7683. ± Comparison against base commit e6dd6ca.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 1, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 77a7683. ± Comparison against base commit e6dd6ca.

♻️ This comment has been updated with latest results.

@vashjs vashjs marked this pull request as ready for review August 5, 2024 21:28
@vashjs vashjs requested a review from SergeYvas August 5, 2024 21:40
src/settings/LocationInstitutions.js Show resolved Hide resolved
src/settings/LocationLibraries.js Show resolved Hide resolved
src/settings/LocationLibraries.js Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
71.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@vashjs vashjs merged commit 1a04912 into master Aug 7, 2024
5 of 6 checks passed
@vashjs vashjs deleted the UITEN-299 branch August 7, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants