Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update seed files #76

Conversation

yksflip
Copy link
Collaborator

@yksflip yksflip commented Jul 3, 2024

Merged the hackathon and small seeds and updated the articles to handle the new unit system. Dropped the .nl seed file, because I think it's unnecessary work to further maintain them.

resolves #16

@yksflip yksflip force-pushed the 16-remove-temporary-db-seeds-used-by-this-fork-hackathon-and-fix-the-existing-seeds-for-the-new-db-structure branch from 52d9aeb to 68670d2 Compare July 3, 2024 16:45
Merged the hackathon and small seeds and updated the articles to handle the new unit system.
Dropped the .nl seed file, because I think it's unnecessary work to further maintain them.
@yksflip yksflip force-pushed the 16-remove-temporary-db-seeds-used-by-this-fork-hackathon-and-fix-the-existing-seeds-for-the-new-db-structure branch from 68670d2 to e423ab3 Compare July 3, 2024 16:48
@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9781782102

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.881%

Totals Coverage Status
Change from base Build 9714447341: 0.0%
Covered Lines: 4641
Relevant Lines: 6837

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9781771328

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1688 unchanged lines in 102 files lost coverage.
  • Overall coverage decreased (-24.7%) to 43.191%

Files with Coverage Reduction New Missed Lines %
app/serializers/group_order_article_serializer.rb 1 80.0%
plugins/messages/app/mail_receivers/messages_mail_receiver.rb 1 20.93%
app/controllers/api/v1/configs_controller.rb 1 75.0%
app/models/bank_account.rb 1 63.16%
app/controllers/application_controller.rb 1 87.5%
app/models/invoice.rb 1 74.19%
app/models/membership.rb 1 85.71%
app/serializers/order_article_serializer.rb 1 83.33%
app/controllers/api/v1/user/users_controller.rb 1 75.0%
app/mail_receivers/bounce_mail_receiver.rb 1 44.44%
Totals Coverage Status
Change from base Build 9714447341: -24.7%
Covered Lines: 2953
Relevant Lines: 6837

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024

Pull Request Test Coverage Report for Build 9781819793

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.881%

Totals Coverage Status
Change from base Build 9714447341: 0.0%
Covered Lines: 4641
Relevant Lines: 6837

💛 - Coveralls

@lentschi
Copy link
Contributor

lentschi commented Jul 5, 2024

@yksflip

Merged the hackathon and small seeds and updated the articles to handle the new unit system.

Ah - great, thanks for investing time in this! 🤩

Dropped the .nl seed file, because I think it's unnecessary work to further maintain them.

If I'm not mistaken, you've dropped the .de one too...?

I'm all for it as it makes it easier to maintain and the developers lingua franca is English anyway. But is this decision something we should discuss upstream first? (Or we just merge it and discuss it through the PR.)

@lentschi lentschi merged commit e517eb2 into master Jul 5, 2024
4 checks passed
lentschi pushed a commit that referenced this pull request Jul 26, 2024
Closes #16 

Merged the hackathon and small seeds and updated the articles to handle the new unit system.
Dropped the .nl and .de seed files, because I think it's unnecessary work to further maintain them.
lentschi pushed a commit that referenced this pull request Oct 11, 2024
Closes #16 

Merged the hackathon and small seeds and updated the articles to handle the new unit system.
Dropped the .nl and .de seed files, because I think it's unnecessary work to further maintain them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove temporary db seeds used by this fork ("hackathon") and fix the existing seeds for the new db structure
3 participants