fix: update desmos proposals type display [web-desmos] #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MonikaCat
changed the title
icfor
approved these changes
Nov 1, 2023
| {t(type)} | ||
| <Typography variant="body1"> | ||
| {types.map((type) => ( | ||
| <Typography variant="body1" className="value"> |
There was a problem hiding this comment.
Because inside of a loop, we have to add a key prop here
| @@ -101,8 +109,12 @@ const Overview: FC<{ className?: string; overview: OverviewType }> = ({ classNam | |||
| <Typography variant="body1" className="label"> | |||
| {t('type')} | |||
| </Typography> | |||
| <Typography variant="body1" className="value"> | |||
| {t(type)} | |||
| <Typography variant="body1"> | |||
There was a problem hiding this comment.
Maybe we can remove this parent typography since it is already used inside the loop
| } | ||
| types.forEach((type: string) => { | ||
| if (type === 'parameterChangeProposal') { | ||
| extraDetails = ( |
There was a problem hiding this comment.
So this loop will set extraDetails depending of the last value of the types array, not sure of logic but just to confirm that this is expected
| R.pathOr('', [0, '@type'], overview.content) === '' | ||
| ? getProposalType(R.pathOr('', ['@type'], overview.content)) | ||
| : getProposalType(R.pathOr('', [0, '@type'], overview.content)); | ||
| const types: string[] = []; |
There was a problem hiding this comment.
Because this is used as a dependency of the useCallback hook, I would recommend using useMemo here or the callback will be created every time (not only this line but all the types definition)
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
yarn lintyarn && yarn changeset