-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe global settings #521
Merged
mariobehling
merged 6 commits into
fossasia:development
from
HungNgien:stripe_global_settings
Jan 25, 2025
Merged
Stripe global settings #521
mariobehling
merged 6 commits into
fossasia:development
from
HungNgien:stripe_global_settings
Jan 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces new fields in the global settings to input Stripe keys, which allows the billing information of organizers to be saved when the fields are filled. It also adds a validator to ensure that the Stripe keys are in the correct format. Class diagram for Stripe key validation and settings formclassDiagram
class GlobalSettingsForm {
+__init__(*args, **kwargs)
}
class StripeKeyValidator {
-_prefixes: List[str]
+__init__(prefix: Union[str, List[str]])
+__call__(value: str)
}
class SecretKeySettingsField {
}
GlobalSettingsForm -- SecretKeySettingsField : uses
GlobalSettingsForm -- StripeKeyValidator : uses
note for GlobalSettingsForm "Added new Stripe Connect fields:
- payment_stripe_connect_secret_key
- payment_stripe_connect_publishable_key
- payment_stripe_connect_test_secret_key
- payment_stripe_connect_test_publishable_key"
note for StripeKeyValidator "Validates Stripe keys
with specific prefixes:
- sk_live_, rk_live_
- pk_live_
- sk_test_, rk_test_
- pk_test_"
Flow diagram for Stripe key validation processflowchart TD
A[Start Validation] --> B{Is key empty?}
B -->|Yes| C[Raise ValidationError:
Key cannot be empty]
B -->|No| D{Check key prefix}
D -->|Valid prefix| E[Validation Success]
D -->|Invalid prefix| F[Raise ValidationError:
Invalid key format]
F --> G[Show error message with
expected prefix format]
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
hongquan
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: add fields in the global settings to input Stripe keys, allowing the billing information of organizers to be saved when the fields are filled.
This PR resolves #485
Summary by Sourcery
New Features: