wip: all the 20 plus PRs in one commit #226
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarikrishnanBalagopal
requested review from
anhuong,
Ssukriti and
alex-jw-brooks
as code owners
ashokponkumar
requested changes
Jul 1, 2024
Comment on lines
+444
to
+465
| kwargs["args"] = args | ||
| kwargs["state"] = state | ||
| kwargs["control"] = control |
There was a problem hiding this comment.
Do we need to construct a new kwargs for this? Isn't just passing them in _actions_on_event just enough?
Comment on lines
+43
to
+52
| "on_step_end", | ||
| "on_epoch_begin", | ||
| "on_epoch_end", | ||
| "on_prediction_step", | ||
| "on_predict", | ||
| "on_log", | ||
| "on_train_end", | ||
| "on_train_begin", | ||
| "on_evaluate", | ||
| "on_save", |
There was a problem hiding this comment.
isn't doing this only on on_init_end sufficient?
| logger = logging.get_logger(__name__) | ||
| logger.setLevel(level=logging.DEBUG) | ||
|
|
||
| VALID_LOG_LEVELS = { |
There was a problem hiding this comment.
Comment on lines
+58
to
+65
| if self.log_level == logging.ERROR: | ||
| logger.error(log_msg) | ||
| elif self.log_level == logging.WARNING: | ||
| logger.warning(log_msg) | ||
| elif self.log_level == logging.INFO: | ||
| logger.info(log_msg) | ||
| elif self.log_level == logging.DEBUG: | ||
| logger.debug(log_msg) |
There was a problem hiding this comment.
Can't we use a function like https://github.com/python/cpython/blob/b93386e1c4dbc871148e081ae147f7d1e8d21444/Lib/logging/__init__.py#L1594 instead?
Signed-off-by: Harikrishnan Balagopal <[email protected]>
HarikrishnanBalagopal
force-pushed
the
wip/allthe20prsinone
branch
from
a75e709 to
3abea36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Related issue number
How to verify the PR
Was the PR tested