-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(foundryup): add foundryup self-update #9609
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: 9547 <[email protected]>
Signed-off-by: 9547 <[email protected]>
Thanks @9547! cc @grandizzy what do you think of adding this into the installer? It would make upgrading One concern is that where the rest of the Bash script is highly flexible in allowing users to install from forks we would limit Another concern is that it is possible a failure case (e.g. partial download) could possibly brick cc @sambacha do you have opinions or concerns regarding this proposed update? |
Yep, agree is better to update only from the source repo.
That would be nice to have, though probably unlikely to happen given foundryup size (and could happen also in the current way to update foundryup, by rerunning |
Downloading to a temp file first is required with bash script because the interpreter (bash) is not guaranteed to buffer the entire file in memory when executing. This means that modifying the file while it's running it could cause inconsistencies and weird errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per comment above
Signed-off-by: 9547 <[email protected]>
Motivation
Add a
--self-update
command to update foundryup itself.Solution