Add deprecation info of version flag

[kkawula]

Closes #2828

Introduced changes

Checklist

• Linked relevant issue
• Updated relevant documentation
• Added relevant tests
• Performed self-review of the code
• Added changes to CHANGELOG.md

[ksew1]

It think this would be more readable instead of current macro

use anyhow::Error;
use clap::ValueEnum;
use shared::print::print_as_warning;

const DEPRECATION_MESSAGE: &str = "The '--version' flag is deprecated and will be removed in the future. Version 3 will become the only type of transaction available.";

pub fn parse_version<T: ValueEnum>(s: &str) -> Result<T, String> {
    print_as_warning(&Error::msg(DEPRECATION_MESSAGE));

    let ignore_case = false; // please check if it should be true of false to not make breaking changes

    T::from_str(s, ignore_case)
}

[ksew1]

Additionally, I think it would be better to change the signature of print_as_warning from:

pub fn print_as_warning(error: &Error)

to:

pub fn print_as_warning(error: impl Display)

This way, we wouldn't need to use the awkward workaround &Error::msg(DEPRECATION_MESSAGE) and could simply pass DEPRECATION_MESSAGE directly 😊

[kkawula]

Cool, it will simplify a lot, also some tests can be removed then

[franciszekjob]

1. Shouldn't we update this message then? If someone uses --token we say Use '--version' instead while version will be deprecated too. I think we can just remove Use '--version' instead sentence.
2. CI is failing 👀

Otherwise looks fine 👍

[franciszekjob]

Please resolve conflicts in changelog