Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0-beta #101

Merged
merged 85 commits into from
Nov 17, 2024
Merged

v1.0-beta #101

merged 85 commits into from
Nov 17, 2024

Conversation

fractaledmind
Copy link
Owner

Yes, this is a ground-up rewrite, but it is much better. I learned a ton from the first versions of the gem, but this is a much cleaner and clearer articulation of the functionality. And dropping support for various features (like plain Sidekiq, batched jobs, and iterable steps) makes the whole thing much crisper.

only installation, which creates multiple tables
Use upsert instead of create, and handle possibly nil getters
[after, 1] and [before, 2] are functionally equivalent, so testing both is rather useless. Instead, the JobCrucible now tests an error location before every line in the callstack, then one error location after the last line.
Always work with a hash where tests can store data in different scopes
@fractaledmind fractaledmind merged commit 08b0332 into main Nov 17, 2024
9 of 10 checks passed
@fractaledmind fractaledmind deleted the alpha-1.0 branch November 17, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant