-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0-beta #101
Merged
Merged
v1.0-beta #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only installation, which creates multiple tables
Use upsert instead of create, and handle possibly nil getters
[after, 1] and [before, 2] are functionally equivalent, so testing both is rather useless. Instead, the JobCrucible now tests an error location before every line in the callstack, then one error location after the last line.
Always work with a hash where tests can store data in different scopes
…saction still commits the transaction
…error locations both before and after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yes, this is a ground-up rewrite, but it is much better. I learned a ton from the first versions of the gem, but this is a much cleaner and clearer articulation of the functionality. And dropping support for various features (like plain Sidekiq, batched jobs, and iterable steps) makes the whole thing much crisper.