Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to go to previous dir in tests #99

Open
franciscoaguirre opened this issue Oct 23, 2023 · 0 comments
Open

Make sure to go to previous dir in tests #99

franciscoaguirre opened this issue Oct 23, 2023 · 0 comments
Assignees
@franciscoaguirre
Labels
bug Something isn't working

Comments

@franciscoaguirre
Copy link
Owner

franciscoaguirre commented Oct 23, 2023 •
edited
Loading

All tests run code to go up a couple of dirs.
This is because we reference all shaders from the workspace root but run the tests in each crate's dir.
It's ugly, but it works for now.
We need to make sure at the end of the test we go to the dir where we started, else our tests fail when run in sequence
@franciscoaguirre franciscoaguirre self-assigned this Oct 23, 2023
@franciscoaguirre franciscoaguirre added cleaning DX/Standards/Due diligence bug Something isn't working and removed cleaning DX/Standards/Due diligence labels Oct 23, 2023
@franciscoaguirre franciscoaguirre changed the title All tests run code for going up some dirs Make sure to go to previous dir in tests Oct 23, 2023
@franciscoaguirre franciscoaguirre mentioned this issue Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@franciscoaguirre franciscoaguirre

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@franciscoaguirre