-
Notifications
You must be signed in to change notification settings - Fork 821
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test(refactor): use consistent dates in all salary withholding tests
- currently 1 test uses hardcoded dates from 2024, while others use dynamic dates from current year, leading to missing salary structure assignment validations - use the same dates in all tests, no need to test this against dynamic data
- Loading branch information
1 parent
e26b49d
commit 689e9d8
Showing
1 changed file
with
34 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,14 +3,20 @@ | |
|
|
||
| import frappe | ||
| from frappe.tests import IntegrationTestCase | ||
| from frappe.utils import get_first_day, get_year_start, getdate | ||
| from frappe.utils import getdate | ||
|
|
||
| from erpnext.setup.doctype.employee.test_employee import make_employee | ||
|
|
||
| from hrms.payroll.doctype.payroll_entry.payroll_entry import get_start_end_dates | ||
| from hrms.payroll.doctype.payroll_entry.test_payroll_entry import make_payroll_entry | ||
| from hrms.payroll.doctype.salary_structure.test_salary_structure import make_salary_structure | ||
|
|
||
| COMPANY_NAME = "_Test Company" | ||
| MONTH_1_START = getdate("2024-01-01") | ||
| MONTH_1_END = getdate("2024-01-31") | ||
| MONTH_2_START = getdate("2024-02-01") | ||
| MONTH_2_END = getdate("2024-02-29") | ||
|
|
||
|
|
||
| class TestSalaryWithholding(IntegrationTestCase): | ||
| def setUp(self): | ||
|
|
@@ -26,28 +32,36 @@ def setUp(self): | |
| ]: | ||
| frappe.db.delete(dt) | ||
|
|
||
| self.company = frappe.get_doc("Company", "_Test Company") | ||
| self.employee1 = make_employee("[email protected]", company=self.company, designation="Engineer") | ||
| self.employee2 = make_employee("[email protected]", company=self.company, designation="Engineer") | ||
| self.company = frappe.get_doc("Company", COMPANY_NAME) | ||
| self.employee1 = make_employee("[email protected]", company=COMPANY_NAME, designation="Engineer") | ||
| self.employee2 = make_employee("[email protected]", company=COMPANY_NAME, designation="Engineer") | ||
|
|
||
| self.today = getdate() | ||
| year_start = get_year_start(self.today) | ||
| make_salary_structure("Test Withholding", "Monthly", employee=self.employee1, from_date=year_start) | ||
| make_salary_structure("Test Withholding", "Monthly", employee=self.employee2, from_date=year_start) | ||
| make_salary_structure( | ||
| "Test Withholding", | ||
| "Monthly", | ||
| company=COMPANY_NAME, | ||
| employee=self.employee1, | ||
| from_date=MONTH_1_START, | ||
| ) | ||
| make_salary_structure( | ||
| "Test Withholding", | ||
| "Monthly", | ||
| company=COMPANY_NAME, | ||
| employee=self.employee2, | ||
| from_date=MONTH_1_START, | ||
| ) | ||
|
|
||
| def test_set_withholding_cycles_and_to_date(self): | ||
| from_date = getdate("2024-06-01") | ||
| to_date = getdate("2024-07-31") | ||
| withholding = create_salary_withholding(self.employee1, from_date, 2) | ||
| withholding = create_salary_withholding(self.employee1, MONTH_1_START, 2) | ||
|
|
||
| self.assertEqual(withholding.to_date, to_date) | ||
| self.assertEqual(withholding.cycles[0].from_date, from_date) | ||
| self.assertEqual(withholding.cycles[0].to_date, getdate("2024-06-30")) | ||
| self.assertEqual(withholding.cycles[1].from_date, getdate("2024-07-01")) | ||
| self.assertEqual(withholding.cycles[1].to_date, to_date) | ||
| self.assertEqual(withholding.to_date, MONTH_2_END) | ||
| self.assertEqual(withholding.cycles[0].from_date, MONTH_1_START) | ||
| self.assertEqual(withholding.cycles[0].to_date, MONTH_1_END) | ||
| self.assertEqual(withholding.cycles[1].from_date, MONTH_2_START) | ||
| self.assertEqual(withholding.cycles[1].to_date, MONTH_2_END) | ||
|
|
||
| def test_salary_withholding(self): | ||
| withholding = create_salary_withholding(self.employee1, get_first_day(self.today), 2) | ||
| withholding = create_salary_withholding(self.employee1, MONTH_1_START, 2) | ||
| withholding.submit() | ||
| payroll_entry = self._make_payroll_entry() | ||
|
|
||
|
|
@@ -61,7 +75,7 @@ def test_salary_withholding(self): | |
| self.assertEqual(withholding.status, "Withheld") | ||
|
|
||
| def test_release_withheld_salaries(self): | ||
| withholding = create_salary_withholding(self.employee1, get_first_day(self.today), 2) | ||
| withholding = create_salary_withholding(self.employee1, MONTH_1_START, 2) | ||
| withholding.submit() | ||
|
|
||
| def test_run_payroll_for_cycle(withholding_cycle): | ||
|
|
@@ -106,7 +120,7 @@ def test_run_payroll_for_cycle(withholding_cycle): | |
| self.assertEqual(payroll_employee.is_salary_withheld, 1) | ||
|
|
||
| def _make_payroll_entry(self, date: str | None = None): | ||
| dates = get_start_end_dates("Monthly", date or self.today) | ||
| dates = get_start_end_dates("Monthly", date or MONTH_1_START) | ||
| return make_payroll_entry( | ||
| start_date=dates.start_date, | ||
| end_date=dates.end_date, | ||
|
|
@@ -117,7 +131,7 @@ def _make_payroll_entry(self, date: str | None = None): | |
|
|
||
| def _submit_bank_entry(self, bank_entry: dict): | ||
| bank_entry.cheque_no = "123456" | ||
| bank_entry.cheque_date = self.today | ||
| bank_entry.cheque_date = MONTH_1_START | ||
| bank_entry.submit() | ||
|
|
||
| def _get_payroll_employee_row(self, payroll_entry: dict) -> dict | None: | ||
|
|
||