-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Salary Component & Structure enhancements #1204
Merged
ruchamahabal
merged 29 commits into
frappe:develop
from
krantheman:salary-component-enhancement
Feb 6, 2024
Merged
feat: Salary Component & Structure enhancements #1204
ruchamahabal
merged 29 commits into
frappe:develop
from
krantheman:salary-component-enhancement
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1204 +/- ##
===========================================
+ Coverage 72.46% 72.57% +0.11%
===========================================
Files 201 201
Lines 10986 11024 +38
===========================================
+ Hits 7961 8001 +40
+ Misses 3025 3023 -2
|
1 task
ruchamahabal
reviewed
Feb 5, 2024
ruchamahabal
reviewed
Feb 5, 2024
krantheman
changed the title
feat: Salary Component enhancements
feat: Salary Component & Structure enhancements
Feb 5, 2024
- get salary structures linked to component if not provided
ruchamahabal
approved these changes
Feb 6, 2024
ruchamahabal
added a commit
that referenced
this pull request
Feb 6, 2024
…1204 feat: Salary Component & Structure enhancements (backport #1204)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Synax highlighting for Formula
Autocompletions for Condition & Formula of the following values -
Option to sync Condition & Formula updates to existing Salary Structures
B * 0.1
B * 0.2
and click on Sync FormulaWarning for when Salary Component is created without setting Accounts
Documentation
https://frappehr.com/docs/v14/en/salary-component