Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mobile friendly Job Portal #1332

Merged
merged 14 commits into from
Jan 31, 2024

Conversation

krantheman
Copy link
Member

@krantheman krantheman commented Jan 18, 2024

Closes: #1286

The updates made to the Job Portal lacked responsiveness. This PR fixes that.

It also fixes

  • Issues with the rendering of published/deleted Job Openings caused due to caching

  • Utilization of card space by the Job Title for when there is no Employment Type

Screenshots

  • Main Portal

image

  • Main Portal filters

image

  • Individual Opening

image

no-docs

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (eb5a77e) 72.44% compared to head (72f2a07) 72.44%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1332   +/-   ##
========================================
  Coverage    72.44%   72.44%           
========================================
  Files          201      201           
  Lines        10978    10986    +8     
========================================
+ Hits          7953     7959    +6     
- Misses        3025     3027    +2     
Files Coverage Δ
...r/doctype/attendance_request/attendance_request.py 82.97% <50.00%> (ø)
hrms/payroll/doctype/salary_slip/salary_slip.py 86.49% <77.77%> (-0.01%) ⬇️
hrms/www/jobs/index.py 0.00% <0.00%> (ø)

@ruchamahabal
Copy link
Member

@mergify update

Copy link
Contributor

mergify bot commented Jan 31, 2024

update

✅ Branch has been successfully updated

@ruchamahabal ruchamahabal changed the title fix: responsiveness for Job Portal feat: mobile friendly Job Portal Jan 31, 2024
@ruchamahabal ruchamahabal merged commit eded9ce into frappe:develop Jan 31, 2024
8 checks passed
ruchamahabal added a commit that referenced this pull request Jan 31, 2024
…1332

feat: mobile friendly Job Portal (backport #1332)
@krantheman krantheman deleted the responsive-job-portal branch January 31, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job Opening on Website do not show correctly
3 participants