feat(Payroll): Option to use Email Template when send Salary Slip email #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittiu
force-pushed
the
v15-salary_slip_email_template
branch
from
79955a3 to
585d9ed
Compare
kittiu
force-pushed
the
v15-salary_slip_email_template
branch
from
585d9ed to
b8c1b12
Compare
|
Test added. Anything else need to be done? |
|
@ruchamahabal I already added test, but most problem test is from other module, what to do. |
|
@Mergifyio update |
✅ Branch has been successfully updated |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1350 +/- ##
===========================================
- Coverage 72.49% 72.45% -0.04%
===========================================
Files 201 201
Lines 10978 10985 +7
===========================================
+ Hits 7958 7959 +1
- Misses 3020 3026 +6
|
|
Anything else? @ruchamahabal |
ruchamahabal
approved these changes
Jan 31, 2024
ruchamahabal
added a commit
that referenced
this pull request
Jan 31, 2024
…1350 feat(Payroll): Option to use Email Template when send Salary Slip email (backport #1350)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the standard message "Please see attachment" on email salary slip is too raw. It is better to use email template.
Docs added here: https://frappehr.com/docs/v14/en/salary-slip#3-4-bulk-email-salary-slips