Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release v14 #1361

Merged
merged 2 commits into from
Jan 31, 2024
Merged

chore: release v14 #1361

merged 2 commits into from
Jan 31, 2024

Conversation

frappe-pr-bot
Copy link
Collaborator

Automated Release.

@mergify @barredterra @ruchamahabal
fix: typos (backport #1351) (#1353)
3ae5354 
* fix: typos (#1351)

(cherry picked from commit b57ec34)

* chore: delete unused file

---------

Co-authored-by: Raffael Meyer <[email protected]>
Co-authored-by: Rucha Mahabal <[email protected]>
@KerollesFathy @ruchamahabal
fix: get income tax slabs by getting ss_assignment based on from_date (…
fe38ef2 
…#1338)

* fix: get income tax slabs by getting ss_assignment base on from_date

* test: get_income_tax_slabs on salary slip dt

* format the code

* remove spaces

Co-authored-by: Rucha Mahabal <[email protected]>

* test: get correct income tax slab

* test: fix loan test

---------

Co-authored-by: Rucha Mahabal <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1d4f89c) 74.27% compared to head (fe38ef2) 74.26%.
Report is 29 commits behind head on version-14.

Additional details and impacted files 
@@              Coverage Diff               @@
##           version-14    #1361      +/-   ##
==============================================
- Coverage       74.27%   74.26%   -0.02%     
==============================================
  Files             194      194              
  Lines           10186    10207      +21     
==============================================
+ Hits             7566     7580      +14     
- Misses           2620     2627       +7
Files Coverage Δ
...ms/hr/doctype/employee_advance/employee_advance.py 89.85% <100.00%> (+0.30%) ⬆️
...ms/hr/doctype/leave_allocation/leave_allocation.py 97.40% <100.00%> (ø)
...r/doctype/leave_ledger_entry/leave_ledger_entry.py 90.47% <ø> (ø)
...ms/hr/doctype/shift_assignment/shift_assignment.py 94.42% <100.00%> (+0.16%) ⬆️
...t/employee_leave_balance/employee_leave_balance.py 96.26% <100.00%> (+0.03%) ⬆️
...enefit_application/employee_benefit_application.py 72.78% <ø> (ø)
hrms/payroll/doctype/salary_slip/salary_slip.py 86.19% <100.00%> (-0.49%) ⬇️
hrms/setup.py 21.25% <ø> (ø)
...satory_leave_request/compensatory_leave_request.py 88.75% <90.00%> (+2.08%) ⬆️
hrms/hr/doctype/exit_interview/exit_interview.py 89.33% <0.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

@ruchamahabal ruchamahabal merged commit 3131b4e into version-14 Jan 31, 2024
10 checks passed
@frappe-pr-bot
Copy link
Collaborator Author

🎉 This PR is included in version 14.21.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal Awaiting requested review from ruchamahabal ruchamahabal is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frappe-pr-bot @codecov-commenter @ruchamahabal @KerollesFathy