fix: update status of gratuity record referenced in fnf #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this the replacement of the old PR? Close this then - #2380 |
ruchamahabal
changed the title
| gratuity.db_set("paid_amount", amount) | ||
| if self.docstatus == 2: | ||
| gratuity.set_status(cancel=True) | ||
|
|
There was a problem hiding this comment.
- Skip the db.exists call since doc deletion is not allowed if it has some linking
on_changewill run on validate + deletion &db_setcalls too. We just need this to run onon_submitandon_cancel- gratuity.set_status needs to be called in both the cases. On updating paid amount or cancelling FnF too
- Reduce nesting in the function
There was a problem hiding this comment.
Thanks, Rucha!
Changes implemented:
- refactor code for updating status of gratuity records
- set_status is called on linked gratuity docs whenever the FNF is canceled or its payment status is updated via the update_full_and_final_statement_status function.
There was a problem hiding this comment.
Made a few changes:
set_status is called on linked gratuity docs whenever the FNF is canceled
Removed this. Realized that payment is handled via JV so cancelling FnF -> cancel JV (linked document cancellation) -> update status for gratuity. Not really needed on FnF cancellation too
Added a filter in FnF child table to prevent cancelled document selection.
…urnal entry" This reverts commit 9079dbb.
- payment is handled via JV so cancelling FnF -> cancel JV -> update status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Gratuity record is referenced under Payables in a Full and Final statement, and the statement is paid, the gratuity record status is updated accordingly. The same update occurs when the Full and Final statement is cancelled.