Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migration): resolve breaking issue in migrate_shift_assignment_schedule_to_shift_schedule.py #2566

Conversation

abdussamadbello
Copy link

@abdussamadbello abdussamadbello commented Jan 2, 2025

Pull Request Description

Target Branch

Target branch: version-15 (or appropriate branch for the fix)


Summary

This PR updates the migrate_shift_assignment_schedule_to_shift_schedule.py script to resolve breaking migration issues in version 15 of ERPNext.


Details

  • Issue Addressed: The migration script for Shift Assignment Schedule caused errors during migration when the related DocType or table was missing in the database.
  • Solution: The updated script adds error handling to gracefully handle missing DocTypes or records. Instead of breaking the migration, errors are logged, and processing continues for valid data.
  • Business Logic: All changes are compliant with the server-side business logic guidelines.
  • Tests: Local testing confirmed the script no longer interrupts migration while preserving intended functionality.

Checklist

--

References


Closes

Closes 2558


Let me know if additional details or adjustments are needed!

@abdussamadbello
Copy link
Author

@krantheman cfb5c85 . This is a fix to the update you made on shift assignment schedule thats breaking the migration

@ruchamahabal
Copy link
Member

Fixed with #2571. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error migrating from erpnext with hrms to 15.47.1
2 participants