fix: correct date handling for get_weekday in shift schedule assignment #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
reviewed
Jan 2, 2025
There was a problem hiding this comment.
Latest get_weekday function handles casting to datetime:
https://github.com/frappe/frappe/blob/ff80d378e63e62b2595b875a67944adfd795fde0/frappe/utils/data.py#L864-L876
But v15 doesn't:
https://github.com/frappe/frappe/blob/afbd449a641e4f129a30fb5136ba891956ae0094/frappe/utils/data.py#L712-L716
Merging for v15
ruchamahabal
approved these changes
Jan 2, 2025
ruchamahabal
pushed a commit
that referenced
this pull request
Jan 2, 2025
…nt (backport #2567) (#2573) Co-authored-by: UmakanthKaspa <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
## [15.37.2](v15.37.1...v15.37.2) (2025-01-08) ### Bug Fixes * correct date handling for get_weekday in shift schedule assignment (backport [#2567](#2567)) ([#2573](#2573)) ([8e9882d](8e9882d)) * **CTC:** `amount_exempted_from_income_tax` only considers last deduction item (exempted from IT), not all (backport [#2568](#2568)) ([#2570](#2570)) ([2fac99d](2fac99d)) * skip patch if previous doctype doesn't exist (backport [#2571](#2571)) ([#2572](#2572)) ([bc4436b](bc4436b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
get_weekdaywas passed a string instead of adatetime.date, causing errors during shift schedule assignment. The fix converts strings todatetime.dateusinggetdate.Related Issue
Closes #2565
Before Fix
before.webm
After Fix
after.webm