fix: mark absence for default shift on non-overlapping dates if another shift assignment exists #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssigned shift exists for the employee but the absent dates aren't overlapping with it chore: added a test for the case
chore: better test scenario
…absent_for_dates_with_no_attendance function takes care of which dates to consider for attendance.
ruchamahabal
reviewed
Jan 9, 2025
asmitahase
added a commit
that referenced
this pull request
Jan 20, 2025
…2602 fix: mark absence for default shift on non-overlapping dates if another shift assignment exists (backport #2602)
asmitahase
added a commit
that referenced
this pull request
Jan 20, 2025
…2602 fix: mark absence for default shift on non-overlapping dates if another shift assignment exists (backport #2602)
This was referenced Jan 23, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Employee isn't marked absent for default shift even when checkins are missing, if another shift assignment exists for future dates
Fix
Updated filter to exclude shift assignments starting on future dates.
Added a test case