fix(SalarySlip): use the correct variable for the function in _get_days_outside_period #2620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the line from
date = add_days(self.end_date, -day)
todate = add_days(end_date, -day)
ensures that the function uses the correctend_date
parameter passed to it, rather than an instance variableself.end_date
. This change aligns with the function's requirements and ensures that the calculation is based on the correct date values provided as arguments.By making this change, the function will correctly calculate the days outside the period, preventing negative values in the
absent_days
field. This leads to accurate payment days and correct salary slip calculations for employees, especially those joining mid-month.closes #2612
backport version-14