rule: no monkey patching

rules/frappe_correctness.py

@@ -186,3 +186,20 @@ def good_cache():
 
 # ruleid: frappe-no-functional-code
 map(lambda x: x, filter(lambda x: x, []))
+
+
+# ruleid: frappe-monkey-patching-not-allowed
+from frappe import permissions
+
+permissions.has_permission = lambda : True
+
+
+# ruleid: frappe-monkey-patching-not-allowed
+from frappe import permissions
+
+permissions.has_permission.xyz = lambda : True
+
+# ruleid: frappe-monkey-patching-not-allowed
+from frappe.permissions import has_permission
+
+has_permission.xyz = lambda : True

rules/frappe_correctness.yml

@@ -313,3 +313,38 @@ rules:
     This call will publish message to everyone on site, do you really want that? Specify doctype, docname, room or user.
   languages: [python]
   severity: ERROR
+
+- id: frappe-monkey-patching-not-allowed
+  patterns:
+    - pattern-either:
+      - pattern: |
+          from $X import $Y
+          ...
+          $Y.$PROPERTY = ...
+      - pattern: |
+          from $X import $Y
+          ...
+          $Y.$Z.$PROPERTY = ...
+      - pattern: |
+          from $X import $Y
+          ...
+          $Y.$Z.$F.$PROPERTY = ...
+      - pattern: |
+          from $X import $Y
+          ...
+          $Y.$Z.$F.$K.$PROPERTY = ...
+      - pattern: |
+          from $X import $Y
+          ...
+          $Y.$Z.$F.$K.$J.$PROPERTY = ...
+      - pattern: |
+          from $X import $Y
+          ...
+          $Y.$Z.$F.$K.$J.$L.$PROPERTY = ...
+  message: |
+    $PROPERTY being monkey patched by app. Use hooks provided by framework instead of patching behaviour at runtime.
+  paths:
+      exclude:
+        - "**/test_*.py"
+  languages: [python]
+  severity: ERROR