Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated collections.Iterable by collections.abc.Iterable #24

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Replace deprecated collections.Iterable by collections.abc.Iterable #24

merged 1 commit into from
Sep 9, 2024

Conversation

Defenso-QTH
Copy link
Contributor

@Defenso-QTH Defenso-QTH commented Sep 8, 2024 •
edited
Loading

Fix #20: remaining collections.Iterable in iocage_lib/ioc_common.py

Make sure to follow and check these boxes before submitting a PR! Thank you.

dgeo
dgeo approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@dgeo dgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I missed this one

@coveralls
Copy link

coveralls commented Sep 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10756877162

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 7.795%
Totals Coverage Status
Change from base Build 9926936252: 0.0%
Covered Lines: 798
Relevant Lines: 7755
💛 - Coveralls

@dgeo dgeo merged commit 9c08450 into freebsd:master Sep 9, 2024
2 checks passed
@dgeo
Copy link
Contributor

dgeo commented Sep 9, 2024

Thank you !

@Defenso-QTH Defenso-QTH deleted the fix-collections.Iterable branch September 9, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgeo dgeo dgeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iocage error when updating
3 participants
@Defenso-QTH @coveralls @dgeo