Implement Users page #2
Conversation
| return env.randomFirstName().map(UsersAction.setFirstName).eraseToEffect() | ||
|
|
||
| case .onDisappear: | ||
| return .cancel(id: RandomGeneratorTimerId.self) |
There was a problem hiding this comment.
Ideally we keep the RandomGeneratorTimerId as part of the RandomGenerator domain. For cancellation we could implement a cancel method in the RandomGenerator and just invoke it from here.
There was a problem hiding this comment.
@nanocba Thanks! Fixed!
|
|
||
| struct UserInfoState: Equatable { | ||
| var user: User | ||
| var disabled: Bool = false |
There was a problem hiding this comment.
I've been exploring with the idea of moving this type of variables to the view since this is merely view configuration that doesn't change at runtime.
| text: viewStore.binding(get: \.job, send: UserInfoAction.jobChanged) | ||
| ) | ||
| } | ||
| }.disabled(viewStore.disabled) |
There was a problem hiding this comment.
To make this view more composable and also being able to remove the disabled from state, you could remove this view modifier from here and just let the callers decide whether they want this view disabled or not i.e. UserDetailView will apply this view modifier while EditUserView will not.
There was a problem hiding this comment.
@nanocba Thanks! Fixed!
Users page preview gif