-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add v2019.1 release notes #1815
Conversation
1b2d0f1
to
7758b19
Compare
7758b19
to
b0ce738
Compare
9ad4768
to
980f10f
Compare
980f10f
to
966d34d
Compare
5fb1433
to
57be513
Compare
AFAIR Gluon 2019.1 is the last release set to be released with batadv-legacy. Maybe this should be noted in the release notes? Same goes for IBSS. |
57be513
to
89c724e
Compare
Added to important notes, sorted important notes by estimated attention span of the average reader. 😄 |
6f49151
to
802b996
Compare
sure, but are they part of "Add v2019.1 release notes" ? |
Sure, was going to add them as soon as the release notes were ready, might as well do it now. |
no they are not. I also disagree that new numbers are required. instead the document should be reworded such that it doesn't age as much. Maybe instead show how to obtain a list of releases and then use placeholders? BUT this is not a discussion that must happen before tagging the next release nor does it have to be in this very issue. |
It's usually this commit that gets the updated version numbers and gets tagged as the release. If someone comes up with a scheme on how to do less version number updates on every release that's fine by me. |
@mweinelt could you also remove unnecessary whitespaces e.g. at the end of lines? |
8db9063
to
0ab245a
Compare
Sounds good.
…On 9/17/19 12:37 AM, bobcanthelpyou wrote:
***@***.**** commented on this pull request.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
In docs/releases/v2019.1.rst <#1815 (comment)>:
> + - RT-AC57U [#noibss]_
+
+.. [#deprecated]
+ This target will be reaching its end of life soon.
+
+.. [#newtarget]
+ This is a new target.
+
+.. [#noibss]
+ Device or target does not support AP+IBSS mode: This device or target will not be built
+ when *GLUON_WLAN_MESH* is set to ``ibss``.
+
+
+.. note::
+
+ The ``ipq806x`` target has been flagged as broken, as all of its devices are not yet fully supported in this OpenWrt release. You might have to update your build scripts accordingly.
Maybe put it at the end of the sentence? https://dictionary.cambridge.org/de/grammatik/britisch-grammatik/yet
|as all of its devices are not fully supported in this OpenWrt release yet|
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1815?email_source=notifications&email_token=AABAED2XPHGCWKLYQ6LGNZ3QKADCJA5CNFSM4IWW2QV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCE4NKAA#discussion_r324914855>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABAED4B7B3ROXUMRKKRXIDQKADCJANCNFSM4IWW2QVQ>.
|
0ab245a
to
4588776
Compare
Done. :%s/\s\+$//e <3
…On 9/17/19 12:44 AM, bobcanthelpyou wrote:
@mweinelt <https://github.com/mweinelt> could you also remove unnecessary whitespaces e.g. at the end of lines?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#1815?email_source=notifications&email_token=AABAED7PZ7UPWMLBEAFQGH3QKAD6BA5CNFSM4IWW2QV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD62XRXI#issuecomment-531986653>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABAED5N2DH7DNF67YO3UJDQKAD6BANCNFSM4IWW2QVQ>.
|
the value |
https://github.com/freifunk-gluon/gluon/pull/1815/files#diff-85f9925dc36f69c841c17388fc2ebb96R160 |
4588776
to
3d37144
Compare
3d37144
to
fab7589
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Besides the marked style issues, there is one more change that should be mentioned: We now include gluon-radvd by default.
fab7589
to
02442c8
Compare
02442c8
to
c0be946
Compare
c0be946
to
90528f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some batman-adv and multicast related comments.
90528f3
to
2d09e28
Compare
2d09e28
to
ca36317
Compare
I'm thankful for so many insightful remarks this time round. The v2019.1 release is out, I've just branched v2019.1.x, the final release notes are up on readthedocs: https://gluon.readthedocs.io/en/v2019.1/releases/v2019.1.html. |
Here we are. Review me!
Thanks to @blocktrron for the help writing some parts of this piece.
Preview: https://shells.darmstadt.ccc.de/~hexa/gluon/1815/