-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge v1.0.0-rc6xx into v1.x.x #1042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To exclude PV inverters that didn't send any data. The power distributor crashes because it tried to get data from a component that didn't send any data since the application startup. Signed-off-by: Elzbieta Kotulska <[email protected]>
If desired power is already reached without the need to use some inverters, their powers need to be set to zero. If not, their original powers would remain and the target powers would be wrong. In case the requested power is zero, this was also leading to crashes because there were no allocations. This change also fixes that issue. Signed-off-by: Sahas Subramanian <[email protected]>
To exclude PV inverters that didn't send any data. The power distributor crashes because it tried to get data from a component that didn't send any data since the application startup.
Signed-off-by: cwasicki <[email protected]>
If there are no gaps in the ring buffer and the new value is missing and creates a gap in time, we need to start the new gap after the latest value from before. Signed-off-by: cwasicki <[email protected]>
) If there are no gaps in the ring buffer and the new value is missing and creates a gap in time, we need to start the new gap after the latest value from before. Fixes frequenz-floss#646.
`Task.exception()` returns raised exceptions as values, unless tasks raised `CancelledError`, in which case, `Task.exception()` raises `CancelledError` as well: https://docs.python.org/3/library/asyncio-task.html#asyncio.Task.exception `Task.result()` provides a more consistent interface, by always re-raising all caught exceptions. Signed-off-by: Sahas Subramanian <[email protected]>
Signed-off-by: Sahas Subramanian <[email protected]>
This is a backport of frequenz-floss#1020 to 1.0.0-rc-6xx
github-actions
bot
added
part:docs
Affects the documentation
part:tests
Affects the unit, integration and performance (benchmarks) tests
part:data-pipeline
Affects the data pipeline
part:microgrid
Affects the interactions with the microgrid
labels
Aug 21, 2024
llucax
force-pushed
the
merge-rc6xx
branch
2 times, most recently
from
August 21, 2024 06:53
c908250
to
c36a8ea
Compare
Oh, it seems we have more issues with |
shsms
approved these changes
Aug 21, 2024
Needs a rebase on top of #1043 to fix the CI. |
# By Sahas Subramanian (3) and others # Via GitHub (3) and Sahas Subramanian (1) * upstream/v1.0.0-rc6xx: Update release notes Replace `Task.exception()` with `Task.result()` Fix gap in ring buffer when updating a missing value Clear release notes Set zero power for PV inverters not neccessary to reach target power Fix PV power distribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
part:data-pipeline
Affects the data pipeline
part:docs
Affects the documentation
part:microgrid
Affects the interactions with the microgrid
part:tests
Affects the unit, integration and performance (benchmarks) tests
type:bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls one bug fix from rc6xx that weren't ported to v1.x.x:
We merge the branches anyway to make it perfectly clear and obvious that now all changes in 6xx were incorporated to v1.x.x.