Add button to import settings from .editorconfig file #615
Conversation
There was a problem hiding this comment.
As expressed in #436, I'm not really a fan of this feature.
It will lead to users reporting problems where dozens of settings will have no impact on the actual problem they are trying to report. I'm not at all motivated to triage issues where the bug wasn't reproduced with the smallest possible sample.
This on a practical side will also lead to long URLs which GitHub won't support for the issue creation.
Could we find some middle ground and work out some sort of two-way binding system with the settings UI? Maybe we add a textarea to paste your relevant editor config settings. If the text changes, we update the settings in the Model. If the settings change via the UI, we update the editorconfig text.
| "resolved": "6.0.0", | ||
| "contentHash": "/iUeP3tq1S0XdNNoMz5C9twLSrM/TH+qElHkXWaPvuNOt+99G75NrV0OS2EqHx5wMN7popYjpc8oTjC1y16DLg==" | ||
| }, | ||
| "fantomas.core": { |
| | _ -> failwithf $"Cannot decode `{line}`" | ||
|
|
||
| let decodeOptionsFromEditorConfigFile (currentSettings: Map<string, FantomasOption>) (fileText: string) = | ||
| fileText.Split([| Environment.NewLine |], StringSplitOptions.RemoveEmptyEntries) |
There was a problem hiding this comment.
This won't quite work when there are multiple sections.
This will assume all settings found will apply.
Might be confusing for the users.
This adds an input to try and load settings directly from an editorconfig file to simplify the repro process. Something is still off (I think it's related to the
orderparam on the options) because it doesn't always load properly but it's close.