Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use float comparison within delta for gradient angle #5087

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Use float comparison within delta for gradient angle #5087

merged 1 commit into from
Aug 28, 2024

Conversation

dweymouth
Copy link
Contributor

Description:

Ensures that float rounding errors will not prevent a linear gradient at 0, 90, 180, 270 degrees from using the optimized code

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 66.04% (+0.008%) from 66.032%
when pulling b3c087c on dweymouth:gradient-float-comparison
into 4182cb2 on fyne-io:develop.

andydotxyz
andydotxyz approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dweymouth dweymouth merged commit 7aa9c4e into fyne-io:develop Aug 28, 2024
11 checks passed
@dweymouth dweymouth deleted the gradient-float-comparison branch August 28, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweymouth @coveralls @andydotxyz