File Label Edit restrictions and Auto-Generate FacilityNumber for RN #186
tom-karaschdotnet-test.yml
on: pull_request
Run unit tests
2m 43s
Annotations
7 errors and 10 warnings
|
Run unit tests:
tests/FMS.App.Tests/Helpers/GeoCoordHelperTests.cs#L46
'GeoCoordHelper' does not contain a definition for 'BothZeroOrBothNonzero'
|
|
Run unit tests:
tests/FMS.App.Tests/Helpers/GeoCoordHelperTests.cs#L52
'GeoCoordHelper' does not contain a definition for 'BothZeroOrBothNonzero'
|
|
Run unit tests:
tests/FMS.App.Tests/Helpers/GeoCoordHelperTests.cs#L60
'GeoCoordHelper' does not contain a definition for 'BothZeroOrBothNonzero'
|
|
Run unit tests:
tests/FMS.App.Tests/Helpers/GeoCoordHelperTests.cs#L46
'GeoCoordHelper' does not contain a definition for 'BothZeroOrBothNonzero'
|
|
Run unit tests:
tests/FMS.App.Tests/Helpers/GeoCoordHelperTests.cs#L52
'GeoCoordHelper' does not contain a definition for 'BothZeroOrBothNonzero'
|
|
Run unit tests:
tests/FMS.App.Tests/Helpers/GeoCoordHelperTests.cs#L60
'GeoCoordHelper' does not contain a definition for 'BothZeroOrBothNonzero'
|
|
Run unit tests
Process completed with exit code 1.
|
|
Run unit tests:
FMS.Infrastructure/Migrations/20240305210424_UpdateSPnearbyFacilities2.cs#L17
Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation. (https://rules.sonarsource.com/csharp/RSPEC-1186)
|
|
Run unit tests:
FMS.Infrastructure/Migrations/20240223163127_UpdateSPgetNearbyFacilities.cs#L46
Use 'Guid.NewGuid()' or 'Guid.Empty' or add arguments to this GUID instantiation. (https://rules.sonarsource.com/csharp/RSPEC-4581)
|
|
Run unit tests:
FMS/Helpers/URLHelper.cs#L40
'WebRequest.Create(string)' is obsolete: 'WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead.' (https://aka.ms/dotnet-warnings/SYSLIB0014)
|
|
Run unit tests:
FMS/Helpers/URLHelper.cs#L35
Remove the unused private method 'RemoteSiteExists'. (https://rules.sonarsource.com/csharp/RSPEC-1144)
|
|
Run unit tests:
FMS/Helpers/FormValidationHelper.cs#L11
Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
|
|
Run unit tests:
FMS/Helpers/FormValidationHelper.cs#L75
Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. (https://rules.sonarsource.com/csharp/RSPEC-3776)
|
|
Run unit tests:
FMS/Pages/Account/ExternalLogin.cshtml.cs#L180
Change this condition so that it does not always evaluate to 'True'. (https://rules.sonarsource.com/csharp/RSPEC-2589)
|
|
Run unit tests:
FMS/Pages/Account/Index.cshtml.cs#L21
'System.Exception' should not be thrown by user code. (https://rules.sonarsource.com/csharp/RSPEC-112)
|
|
Run unit tests:
tests/FMS.Infrastructure.Tests/CabinetRepositoryTest.cs#L190
Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
|
|
Run unit tests:
tests/FMS.Infrastructure.Tests/CabinetRepositoryTest.cs#L230
Test methods should not call ConfigureAwait(false), as it may bypass parallelization limits. Omit ConfigureAwait, or use ConfigureAwait(true) to avoid CA2007. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
|