Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

267 modify existing entities to accommodate new data fields #307

Conversation

tom-karasch
Copy link
Member

Modify Facility Entity and Detail and Create DTOs. Update Details Page

@tom-karasch tom-karasch self-assigned this Dec 5, 2023
@tom-karasch tom-karasch marked this pull request as draft December 5, 2023 22:15
@tom-karasch tom-karasch marked this pull request as ready for review December 6, 2023 16:59
Copy link
Member

@dougwaldron dougwaldron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this PR includes the .NET 8 upgrade code, but my review only relates to the facility entity, DTO, etc. Also, I haven't reviewed any updated entity relationship plans, so I'm only looking at code correctness here.

FMS.Domain/Entities/Facility.cs Show resolved Hide resolved
FMS.Domain/Dto/Facility/FacilityDetailDto.cs Outdated Show resolved Hide resolved
FMS/Pages/Facilities/Details.cshtml Outdated Show resolved Hide resolved
FMS/Pages/Facilities/Index.cshtml Outdated Show resolved Hide resolved
FMS/Pages/Facilities/Details.cshtml Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Dec 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.0% 96.0% Coverage
19.2% 19.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@tom-karasch tom-karasch merged commit 86a7f8f into main Dec 7, 2023
6 of 7 checks passed
@tom-karasch tom-karasch deleted the 267-modify-existing-entities-to-accommodate-new-data-fields-from-access-db branch December 7, 2023 15:41
@amberehall amberehall added this to the 2 - Application Coding milestone Dec 7, 2023
@amberehall amberehall added the Sub-Task Project Sub-Task label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sub-Task Project Sub-Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify existing Entities to accommodate new data fields from Access DB.
3 participants