Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions - Add-Edit Facilities as per UAT notes #371

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Permissions - Add-Edit Facilities as per UAT notes #371

merged 2 commits into from
Mar 20, 2024

Conversation

tom-karasch
Copy link
Member

Change Permissions as follows:

  • File Label update option should only be provided to Facility Editor when there is not a File Label assigned. If there is already a File Label assigned, Site Maintenance role should be only role that sees File Label update option.
  • Should not be able to duplicate Notification or HSI Facility Nos. See screenshot below. Logic appears to prevent this on Add Facility screen, but not on Edit screen.

@tom-karasch tom-karasch added enhancement request New feature or request high priority Critical issue that should be addressed quickly Code Cleanup Use Best Practice coding labels Mar 11, 2024
@tom-karasch tom-karasch self-assigned this Mar 11, 2024
@tom-karasch tom-karasch linked an issue Mar 11, 2024 that may be closed by this pull request
Set permissions for Add/Edit Facility Pages as per UAT #370
Closed
@tom-karasch
Copy link
Member Author

Closes #370
Closes #378

@tom-karasch tom-karasch merged commit 0d0221f into Dev Mar 20, 2024
3 of 5 checks passed
@tom-karasch tom-karasch deleted the 370-set-permissions-for-add-edit-facility-pages-as-per-uat branch March 20, 2024 20:22
@tom-karasch tom-karasch mentioned this pull request Mar 20, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tom-karasch tom-karasch

Labels
Code Cleanup Use Best Practice coding enhancement request New feature or request high priority Critical issue that should be addressed quickly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set permissions for Add/Edit Facility Pages as per UAT
1 participant
@tom-karasch