Drop tool migration scripts and related code #13099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdavcs
force-pushed
the
dev_migratetools
branch
from
8f69d96 to
3fe5d60
Compare
jdavcs
added
area/database
jdavcs
changed the title
|
All the red is due to a disruption of service on circleci's end. I'll rerun the tests when that's fixed. |
nsoranzo
reviewed
Dec 21, 2021
test/unit/config/config_manage/1607_root_filters/config/galaxy.ini
Outdated
Show resolved
Hide resolved
jdavcs
force-pushed
the
dev_migratetools
branch
from
3fe5d60 to
6df280a
Compare
The from_tool_migration_manager parameter as False as its default value. The only case where it's called with the value True is when it's called from the from_tool_migration_manager module - which is now deleted. Therefore, now the value is always False and, therefore, it is safe to drop this parameter and adjust the code that checks its value accordingly.
jdavcs
force-pushed
the
dev_migratetools
branch
from
6df280a to
263f2db
Compare
|
Looks wonderful to me! |
jmchilton
approved these changes
Dec 21, 2021
jdavcs
added a commit
to jdavcs/galaxy
that referenced
this pull request
Jan 6, 2022
The edit in lib/tool_shed is intentional: it did not refer to the TS-based migrate stuff that still exists. The tangential stuff is on tool migration. The migrate reference was part of the tool-migration enpoint, which itself is dead code, since tool migration has been dropped in galaxyproject#13099. The client code contained references to the endpoint.
jdavcs
added a commit
to jdavcs/galaxy
that referenced
this pull request
Jan 9, 2022
The edit in lib/tool_shed is intentional: it did not refer to the TS-based migrate stuff that still exists. The tangential stuff is on tool migration. The migrate reference was part of the tool-migration enpoint, which itself is dead code, since tool migration has been dropped in galaxyproject#13099. The client code contained references to the endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to a discussion we had at a backend WG meeting.
The functionality is no longer used and, due to its reliance on SQLAlchemy Migrate, is a blocker for #12541 (SQLAlchemy 2.0).
I've left the
migrated_tools_configconfig option, but marked it as deprecated and changed its description accordingly. That way, we still check for that file, in case there's a deployment that still has one. I've removed thecheck_migrate_toolsconfig option and (hopefully) all related functionality.EDIT: I'm not sure to what extent this might affect #636 (thanks for the reference, @nsoranzo!)
How to test the changes?
(Select all options that apply)
License