[24.1] Record implicitly converted dataset as input dataset #19301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
implicit_dataset_as_input
branch
from
0d9a30f to
f10ed72
Compare
which means we collect and store the converted dataset as the job input. We don't need to wait for the galaxy.json collection, we know the exact target type already. That fixes the retrieval in `get_converted_files_by_type`. I believe this was always the intention and is how it works if the dataset already exists (i.e. on a re-run), and for all converters that don't use galaxy.json The converter records the dataset that the user chose, so there's no gap in the provenance either. This somewhat addresses galaxyproject/total-perspective-vortex#141 so you can (reliably) differetiate your rules on the input datatype and filesize combination.
mvdbeek
force-pushed
the
implicit_dataset_as_input
branch
from
f10ed72 to
a75bca5
Compare
|
This has been ready for a while. Test errors are unrelated. |
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by fixing the converter's output dataset extension to the requested extension.
We don't need to wait for the galaxy.json collection, we know the exact target type already. That fixes the retrieval in
get_converted_files_by_type.I believe this was always the intention and is how it works if the dataset already exists (i.e. on a re-run), and for all converters that don't use galaxy.json The converter records the dataset that the user chose, so there's no gap in the provenance either.
This somewhat addresses galaxyproject/total-perspective-vortex#141 so you can (reliably) differentiate your rules on the input datatype and filesize combination.
How to test the changes?
(Select all options that apply)
License