Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.2] Fix simple activity panel item style #19350

Merged

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Dec 19, 2024

This PR adjusts for recent changes to the activity panel. Unnecessary styles are removed from the activity settings panel and now missing styles are restored for the visualizations panel.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Navigate to the Visualizations Panel
    2. Without this PR: Notice that the options are misaligned
    3. With this PR: Verify that the Settings Activity Panel and the Visualizations Panel item look and behave the same

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.2 milestone Dec 19, 2024
@guerler guerler marked this pull request as ready for review December 19, 2024 16:44
@guerler guerler requested a review from ahmedhamidawan January 7, 2025 15:49
Copy link
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well! Thank you!

@ahmedhamidawan ahmedhamidawan merged commit 6d0bff4 into galaxyproject:release_24.2 Jan 7, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants