Alternative format_source fix
#19395
Merged
+136
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point the inputs are ready, so expession.json has been replaced with the true extension.
mvdbeek
force-pushed
the
alternative_format_source_fix
branch
3 times, most recently
from
e5e3498 to
2d5903f
Compare
mvdbeek
force-pushed
the
alternative_format_source_fix
branch
from
2d5903f to
f28ea20
Compare
|
@jmchilton could you take a look at this ? @Delphine-L would need this for her work |
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #19364, fixes #19245
I made the "mistake" of adding type annotations to orient myself, and that sprawled.
I'll pull out the ToolEvaluator changes and target 24.1 with those.
How to test the changes?
(Select all options that apply)
License