Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FactorCosetAction(G, G) for perm. groups #5903

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ThomasBreuer
Copy link
Contributor

Catch the case of an action with trivial image in DoFactorCosetActionPerm, and delegate to DoFactorCosetAction in this case.

resolves #5902

(Just for curiosity:
The code for DoFactorCosetAction and DoFactorCosetActionPerm deals with the case that the second argument is a list (not a group), but only in order to call Error if this list is empty. The functions called later, such as Core and ActionRefinedSeries, do not accept a list as the value of this argument.
Is this list situation meaningful at all?)

Catch the case of an action with trivial image in
`DoFactorCosetActionPerm`,
and delegate to `DoFactorCosetAction` in this case.
@ThomasBreuer ThomasBreuer added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them topic: library release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes backport-to-4.14 labels Jan 10, 2025
@ThomasBreuer ThomasBreuer requested a review from hulpke January 10, 2025 12:47
@ThomasBreuer
Copy link
Contributor Author

I do not understand the remark that the added lines are not covered by tests.
The added test in teststandard should execute these lines of code, I have checked this locally.
What am I missing?

@lgoettgens
Copy link
Contributor

I do not understand the remark that the added lines are not covered by tests. The added test in teststandard should execute these lines of code, I have checked this locally. What am I missing?

If we have a look at the codecov webpage (https://app.codecov.io/gh/gap-system/gap/pull/5903/blob/lib/csetperm.gi#L886), it there states that your added lines are indeed covered (aka are green), while the error case two lines above is uncovered. My assumption is that there is a small offset somewhere in the codecov-to-github interface that mistakenly reports this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-4.14 kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FactorCosetAction fails for non-proper subgroups
3 participants