-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Existing etcd
Clusters with etcd-druid
#957
Open
seshachalam-yv
wants to merge
4
commits into
gardener:master
Choose a base branch
from
seshachalam-yv:feature/migrate-etcd-to-druid
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Integrate Existing etcd
Clusters with etcd-druid
#957
seshachalam-yv
wants to merge
4
commits into
gardener:master
from
seshachalam-yv:feature/migrate-etcd-to-druid
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `ExistingCluster` struct in `EtcdConfig` to specify configuration for an existing etcd cluster. - Added `MemberURLs` and `Endpoint` fields to `ExistingCluster` to define the URLs and endpoint of the existing etcd cluster members.
…ruid managed cluster
- Updated `prepareInitialCluster` function to include existing cluster member URLs. - Modified `getBackupRestoreContainerCommandArgs` to append existing cluster endpoint to service endpoints.
gardener-robot
added
area/control-plane
Control plane related
area/high-availability
High availability related
kind/enhancement
Enhancement, improvement, extension
needs/review
Needs review
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
labels
Dec 25, 2024
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
label
Dec 25, 2024
gardener-robot-ci-1
added
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
and removed
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
labels
Dec 25, 2024
/test pull-etcd-druid-unit |
/assign |
shreyas-s-rao
assigned ashwani2k, unmarshall and shreyas-s-rao and unassigned ashwani2k and shreyas-s-rao
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/control-plane
Control plane related
area/high-availability
High availability related
kind/enhancement
Enhancement, improvement, extension
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/review
Needs review
size/m
Size of pull request is medium (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane
/area high-availability
/kind enhancement
What this PR does / why we need it:
This PR introduces the necessary changes to
etcd-druid
to enable seamless migration of existingetcd
clusters intoetcd-druid
managed clusters. It includes updates to the API to support theexistingCluster
configuration, which allows clusters that are not initially managed byetcd-druid
to be integrated without disruption.A step-by-step guide is added to demonstrate how to migrate an unmanaged etcd cluster to an etcd-druid managed cluster. By leveraging the
existingCluster
feature, you can create anEtcd
CR configured with your current cluster’s peer URLs and endpoints, prompting etcd-druid to join your existing members. Once the newly managed members are active, you can safely remove the old, unmanaged members. This approach offers a straightforward migration path with minimal downtime.Which issue(s) this PR fixes:
Fixes #956
Special notes for your reviewer:
Release note: