Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Palace plugin for full-wave S-parameters #113

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

nikosavola
Copy link
Member

This PR adds an experimental plugin for Palace that runs driven full-wave frequency-domain FEM and solves the S-parameters.

I consider it experimental as it currently only supports lumped ports, and the results using those seem inaccurate. Nevertheless, simulations can be run with nice field plots as results.

We add:

  • Example in docs
  • Tests

but neither are run in CI, this is deferred to #64.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #113 (a5c55c6) into main (da2c66f) will increase coverage by 0.13%.
Report is 23 commits behind head on main.
The diff coverage is 34.00%.

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   40.01%   40.14%   +0.13%     
==========================================
  Files         168      170       +2     
  Lines       10442    10529      +87     
==========================================
+ Hits         4178     4227      +49     
- Misses       6264     6302      +38     
Files Changed Coverage Δ
gplugins/palace/get_scattering.py 21.13% <21.13%> (ø)
gplugins/palace/tests/test_palace.py 52.80% <45.45%> (-9.20%) ⬇️
gplugins/utils/get_scattering.py 52.17% <52.17%> (ø)
gplugins/palace/__init__.py 100.00% <100.00%> (ø)
gplugins/typings.py 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab
Copy link
Contributor

Looks great! thank you Niko!

@joamatab joamatab merged commit 3c07fee into gdsfactory:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants