Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RF simulation docs formatting slightly #115

Merged

Conversation

nikosavola
Copy link
Member

This PR improves formatting in RF simulation docs slightly:

  • add a hide-input tag to the imports in Palace scattering example
  • add a hide-output tag to Palace simulations (though not yet run in CI, Run Palace tests in CI #64)
  • remove empty lines before code to run

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #115 (244fedb) into main (a5c55c6) will not change coverage.
Report is 20 commits behind head on main.
The diff coverage is 34.69%.

@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   40.14%   40.14%           
=======================================
  Files         170      170           
  Lines       10529    10529           
=======================================
  Hits         4227     4227           
  Misses       6302     6302           
Files Changed Coverage Δ
...umerical/write_sparameters_lumerical_components.py 35.00% <0.00%> (ø)
gplugins/tidy3d/get_simulation.py 71.34% <ø> (ø)
gplugins/femwell/solve_thermal.py 17.64% <11.11%> (ø)
gplugins/web/main.py 36.47% <16.66%> (ø)
gplugins/femwell/__init__.py 100.00% <100.00%> (ø)
gplugins/gmsh/__init__.py 100.00% <100.00%> (ø)
gplugins/gmsh/uz_xsection_mesh.py 63.39% <100.00%> (ø)
gplugins/gmsh/xy_xsection_mesh.py 55.76% <100.00%> (ø)
gplugins/gmsh/xyz_mesh.py 82.35% <100.00%> (ø)
...ugins/path_length_analysis/path_length_analysis.py 58.05% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit 77e749b into gdsfactory:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants