sc-4577 eng workflow #1587
Merged
sc-4577 eng workflow #1587
+86
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalker2m
approved these changes
Jan 24, 2025
| @@ -352,7 +354,7 @@ object ObservationWorkflowService { | |||
| case Inactive => List(executionState.getOrElse(validationStatus)) | |||
| case Undefined => List(Inactive) | |||
| case Unapproved => List(Inactive) | |||
| case Defined => List(Inactive) ++ Option.when(isAccepted)(Ready) | |||
| case Defined => List(Inactive) ++ Option.when(isAccepted || info.tpe === ProgramType.Engineering)(Ready) | |||
There was a problem hiding this comment.
What's true for Engineering is probably true for Calibration and all the others? info.tpe =!= ProgramType.Science
There was a problem hiding this comment.
That is sensible, I'll make that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the workflow for engineering programs such that they never generate validation errors, and thus always start in out as
Defined. This may or may not be entirely correct.The logic here is starting to seem OT-like in its weirdness so we may want to refactor once the dust settles. I'm thinking maybe we also need to change the logic for other types of programs.