Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(zweitausbildung): update routes #1208

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix(zweitausbildung): update routes #1208

wants to merge 4 commits into from

Conversation

oterral
Copy link
Collaborator

@oterral oterral commented Jan 20, 2025 •
edited
Loading

How to

Update routes in zweitausbildung

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • The title means something for a human being and follows the conventional commits specification.
  • The title contains [WIP] if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Tests added.

@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev-trafimage-maps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 0:06am
trafimage-maps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 0:06am

@oterral oterral changed the title fix(zweitausbildung): update routes WIP fix(zweitausbildung): update routes Jan 20, 2025
@oterral oterral changed the title WIP fix(zweitausbildung): update routes fix(zweitausbildung): update routes Jan 21, 2025
@danji90
Copy link
Contributor

danji90 commented Jan 22, 2025

@oterral Please provide more info for reviewing. You also didn't mention me in any ticket, so I have no idea what the task was

danji90
danji90 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@danji90 danji90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.env
@@ -5,6 +5,7 @@ REACT_APP_BASE_URL=//maps.trafimage.ch
REACT_APP_MATOMO_URL_BASE=https://analytics.geops.de/
REACT_APP_MATOMO_SITE_ID=9
REACT_APP_VECTOR_TILES_URL=https://maps.geops.io
REACT_APP_VECTOR_TILES_URL=https://maps.test.geops.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert before merge please

@oterral oterral mentioned this pull request Jan 23, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danji90 danji90 danji90 approved these changes

@friedjoff friedjoff Awaiting requested review from friedjoff friedjoff is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oterral @danji90