Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct README based on feedback of issue #1374 #1380

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Correct README based on feedback of issue #1374 #1380

merged 4 commits into from
Oct 31, 2023

Conversation

shivathapaa
Copy link
Contributor

Overview

This pull request addresses feedback (PR #1376) and makes corrections to the README file based on the discussions in issue #1374.

Related Issue / Discussion

As per feedback based on issue: #1374

  • Made corrections to the README file to address the feedback and suggestions provided.
  • Improved the introduction to accurately describe the role of pygeoapi.
  • Included a link to the SensorThings standard for additional reference.
  • Corrected the number of available STA examples, and moved the Docker Compose description to Additional Information.

These changes resolve issue #1374 and ensure that the README accurately reflects the project's functionality.

Additional Information

  • I changed the title for more clarity, "Setting up a Pygeoapi Server with SensorThings (STA) Using Docker Compose"
  • Feel free to provide feedback or ask for any clarifications if needed.

Contributions and Licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution.
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

Acknowledgments:

Thanks, @doublebyte1, for your continued support. I've resolved the issue by closing and reopening the pull request. Apologies for any inconvenience, but this has been a valuable learning for me. :)

@shivathapaa shivathapaa changed the title Update/sensorthings readme config Correct README based on feedback of issue #1374 Oct 17, 2023
@tomkralidis tomkralidis requested a review from webb-ben October 24, 2023 15:41
@tomkralidis tomkralidis merged commit 981acbc into geopython:master Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants