Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin starlette version #1444

Closed
wants to merge 1 commit into from
Closed

Pin starlette version #1444

wants to merge 1 commit into from

Conversation

webb-ben
Copy link
Member

Overview

Pin starlette version to pass CI tests

Related Issue / Discussion

Additional Information

Contributions and Licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution.
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

Copy link
Contributor

@francbartoli francbartoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @webb-ben, may I ask what's the reason to pin it at a specific version?

@webb-ben
Copy link
Member Author

@francbartoli Master CI & all CI fails due to a response from the starlette section of test_api.py. Documented at #1445

@ricardogsilva
Copy link
Member

ricardogsilva commented Dec 20, 2023

@webb-ben @francbartoli see #1447 for an alternative that focuses on modifying the failing tests instead of pinning starlette - there also a relevant comment on #1445

@webb-ben
Copy link
Member Author

Thanks @ricardogsilva

@webb-ben webb-ben closed this Dec 20, 2023
@webb-ben webb-ben deleted the fix branch December 20, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants