Tiles Metadata provider refactor #1482
Conversation
PascalLike
force-pushed
the
tilesmetadatamethods
branch
from
8893c2c to
199ed39
Compare
There was a problem hiding this comment.
Great work @PascalLike !! 👏🏽
When you have a moment, please remove also these lines in the docs:
It is also worth to remove this line:
https://github.com/geopython/demo.pygeoapi.io/blob/aa257cb51ce52dcc7b66f39be15d30b98b9ffc5e/services/pygeoapi_master/local.config.yml#L158
| <script> | ||
| var select = document.getElementById('tilingScheme'); | ||
| var tileset = select.value; |
There was a problem hiding this comment.
I think this is problematic, because when the page loads, we arrive here with an empty "tileset" variable. It could work, if the map refreshed itself, each time we choose a tileset on the dropdown.
There was a problem hiding this comment.
@PascalLike perfect! This solves the issue 👍🏽
Thanks @doublebyte1 ! I fixed the things you suggested. |
* - refactored mvt classes to support all implemented metadata formats, regardless of the provider * - fixed formatting issues * Implementing basic tile metadata methods * Fixing yml models * Adding additional format * Fixing schema set on load * Removing unused field from documentation * Change method name to generic vendor * Keeping extra metadata info for tippecanoe provider * Fix flake validations error --------- Co-authored-by: doublebyte <[email protected]>
Overview
Following the tiles providers refactor started by @doublebyte1
Related issue / discussion
#1457
#1458
Additional information
There is a PR drafted for demo.pygeoapi.io when this will be merged (geopython/demo.pygeoapi.io#49). Btw this is not a breaking change. As far as I can test, this should not break anything.
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)